hello @arifbalik

Thanks for your contribution! Please find below few comments:

• Could you detail the naming delta?
• Would it be possible to enhance https://github.com/zephyrproject-rtos/hal_stm32/blob/main/scripts/genpinctrl/stm32-pinctrl-config.yaml instead of creating a new file just for the Ethernet? Or do you observe some other differences that require a separate file?
• It also seems that you could close the dts: update stm32mp1 series ethernet pins #288 and add directly the commit in this one as it addresses the same topic
• last request: could you refactor your commit message to 75 char per line?

I was trying to bring up ethernet on stm32mp1 and realized the pin data is quite different than what was specified in the default yml file, I'll see if I can put it inside the default one but it seems unlikely.

Also last time I updated the pinctrl files @erwango suggested that I should open another PR for the dtsi files since they were quite large, i can put it here as well

I updated the pinctrl files @erwango suggested that I should open another PR for the dtsi

Maybe I wasn't clear enough, I wanted to mean splitting into disctinct commits, not PRs.

oh my bad

I was trying to bring up ethernet on stm32mp1 and realized the pin data is quite different than what was specified in the default yml file, I'll see if I can put it inside the default one but it seems unlikely.

perhaps you could just add

- name: ETH_MP1x
  match: "^ETH[12]_(CLK|COL|CRS|CRS_DV|GTX_CLK|MDC|MDIO|PHY_INTN|PPS_OUT|REF_CLK|RX_CLK|RX_CTL|RX_DV|RX_ER|RXD[0-3]|TX_CLK|TX_CTL|TX_EN|TX_ER|TXD[0-3])$"
  slew-rate: very-high-speed

I was trying to bring up ethernet on stm32mp1 and realized the pin data is quite different than what was specified in the default yml file, I'll see if I can put it inside the default one but it seems unlikely.

perhaps you could just add

- name: ETH_MP1x
  match: "^ETH[12]_(CLK|COL|CRS|CRS_DV|GTX_CLK|MDC|MDIO|PHY_INTN|PPS_OUT|REF_CLK|RX_CLK|RX_CTL|RX_DV|RX_ER|RXD[0-3]|TX_CLK|TX_CTL|TX_EN|TX_ER|TXD[0-3])$"
  slew-rate: very-high-speed

The problem is that some of the definitions in the pin data matches some regex expressions inside stm32-pinctrl-config.yaml but not all, so if we just add the expression you provided, we would get some definitions twice.

For example some definitions will match the following regex and this is from stm32-pinctrl-config.yaml

- name: ETH (Extended)
  match: "^ETH\\d+_(?:MDC|MDIO|PHY_INTN|PPS_OUT|CLK|TX_ER)$"
  slew-rate: very-high-speed

But none would match against this;

- name: ETH
  match: "^ETH+_(?:COL$|CRS|CRS_DV|MDC|MDIO|PPS_OUT|REF_CLK|RX_CLK|RX_DV|RX_ER||RXD[0-3]|TX_CLK|TX_EN|TXD[0-3])$"
  slew-rate: very-high-speed

Maybe I could remove the expressions inside EH_MP1x that causes the double match, but then the pinctrl file would call some ETH pins as "extended" even though they are not.

I was trying to bring up ethernet on stm32mp1 and realized the pin data is quite different than what was specified in the default yml file, I'll see if I can put it inside the default one but it seems unlikely.

perhaps you could just add

- name: ETH_MP1x
  match: "^ETH[12]_(CLK|COL|CRS|CRS_DV|GTX_CLK|MDC|MDIO|PHY_INTN|PPS_OUT|REF_CLK|RX_CLK|RX_CTL|RX_DV|RX_ER|RXD[0-3]|TX_CLK|TX_CTL|TX_EN|TX_ER|TXD[0-3])$"
  slew-rate: very-high-speed

The problem is that some of the definitions in the pin data matches some regex expressions inside stm32-pinctrl-config.yaml but not all, so if we just add the expression you provided, we would get some definitions twice.

For example some definitions will match the following regex and this is from stm32-pinctrl-config.yaml

- name: ETH (Extended)
  match: "^ETH\\d+_(?:MDC|MDIO|PHY_INTN|PPS_OUT|CLK|TX_ER)$"
  slew-rate: very-high-speed

But none would match against this;

- name: ETH
  match: "^ETH+_(?:COL$|CRS|CRS_DV|MDC|MDIO|PPS_OUT|REF_CLK|RX_CLK|RX_DV|RX_ER||RXD[0-3]|TX_CLK|TX_EN|TXD[0-3])$"
  slew-rate: very-high-speed

Maybe I could remove the expressions inside EH_MP1x that causes the double match, but then the pinctrl file would call some ETH pins as "extended" even though they are not.

Is Completing the ETH (Extended) not sufficient?
Could you provide some examples of names that would not match, explaining why? This would help us better understand the issue.

If we are unable to enhance the stm32-pinctrl-config.yaml, an alternative could be to include the changes in stm32mp1-pinctrl-config.yaml to only override the ETH section.